GH2400: Add globber pattern support to the #load directive

[gitfool]

Fixes #2400. @patriksvensson almost there; a couple of the existing unit tests are failing though:

• LoadDirectiveProcessorTests.cs#L168
• LoadDirectiveProcessorTests.cs#L206

In both cases the globber is processing absolute paths that don't have any globber patterns in them and returning no files. Any ideas how to handle that?

[gitfool]

@devlead @patriksvensson I had some time to dig into this; found and fixed the issue with the globber not working as expected with unix root paths. Also fixed some Windows tests.

I force pushed the changes, however the Azure Pipelines builds seem to be failing with an unrelated error in the integration tests:

System.PlatformNotSupportedException: Operation is not supported on this platform.
   at Microsoft.CSharp.CSharpCodeGenerator.FromFileBatch(CompilerParameters options, String[] fileNames)
   at Microsoft.CSharp.CSharpCodeGenerator.System.CodeDom.Compiler.ICodeCompiler.CompileAssemblyFromDomBatch(CompilerParameters options, CodeCompileUnit[] ea)
   at Mono.TextTemplating.TemplatingEngine.CompileCode(IEnumerable`1 references, TemplateSettings settings, CodeCompileUnit ccu) in /Users/mikayla/code/t4/Mono.TextTemplating/Mono.TextTemplating/TemplatingEngine.cs:line 271
   at Mono.TextTemplating.TemplatingEngine.CompileTemplateInternal(ParsedTemplate pt, String content, ITextTemplatingEngineHost host) in /Users/mikayla/code/t4/Mono.TextTemplating/Mono.TextTemplating/TemplatingEngine.cs:line 175
   at Mono.TextTemplating.TemplatingEngine.CompileTemplate(ParsedTemplate pt, String content, ITextTemplatingEngineHost host) in /Users/mikayla/code/t4/Mono.TextTemplating/Mono.TextTemplating/TemplatingEngine.cs:line 149
   at Mono.TextTemplating.ToolTemplateGenerator.ProcessTemplate(ParsedTemplate pt, String inputFile, String inputContent, String& outputFile) in /Users/mikayla/code/t4/dotnet-t4/ToolTemplateGenerator.cs:line 59
   at Mono.TextTemplating.TextTransform.MainInternal(String[] args) in /Users/mikayla/code/t4/dotnet-t4/TextTransform.cs:line 194
   at Mono.TextTemplating.TextTransform.Main(String[] args) in /Users/mikayla/code/t4/dotnet-t4/TextTransform.cs:line 42
An error occurred when executing task 'Cake.Common.Tools.TextTransform.TextTransformAliases.TransformTemplate.Properties'.

... and I have the same issue when running the integration tests locally. 🤔

[patriksvensson]

@gitfool The T4 issue have been resolved, but I need to investigate the failing tests a bit. I will try to investigate this as soon as I have some spare time.

[gitfool]

@patriksvensson re the unit tests that are now failing on *nix, I changed them from WindowsTheory to Theory because I thought they should now work on all platforms after I changed ScriptAnalyzerFixture ctor to create a Unix environment when specified.

I could change the attribute back but I'm still curious why they wouldn't work as the file system should be virtualized for the test.

[gitfool]

I would guess the problem is coming from:

• Cake.Testing/FakeEnvironment.cs#L79
  • environment.WorkingDirectory = new DirectoryPath("C:/Working");
• Cake.Core/IO/Path.cs#L98
  • IsRelative = !PathHelper.IsPathRooted(FullPath);
• Cake.Core/IO/PathHelper.cs#L274-L281

    if (_isWindows)
    {
        // Windows drive?
        if (length >= 2 && path[1] == ':')
        {
            return true;
        }
    }

• Cake.Core/IO/PathHelper.cs#L13
  • _isWindows = EnvironmentHelper.GetPlatformFamily() == PlatformFamily.Windows;

i.e. PathHelper does not honor the fake environment.

[gitfool]

@patriksvensson I'm keen to get this PR into the next release, and since the issue with the tests is due to a pre-existing deficiency in the fake test environment, I simply reverted the Windows tests to use WindowsTheory, as before.

[gitfool]

Rebased and squashed the last revert commit for a cleaner merge.

[devlead]

LGTM! 👍 Just about to board a plan so will take this for a spin later.

Could you add a integration test for this ( https://github.com/cake-build/cake/blob/develop/tests/integration/Cake.Core/Scripting/LoadDirective.cake ), preferably with an throw in a file that shouldn't be loaded by globber.

[gitfool]

@devlead I added an integration test that adds a task dependency if loaded. One of the tasks throws an exception, but this does not happen since the globber pattern excludes it, while still loading the other task.

Note: I also tweaked the check for .cake file extension to be earlier so that a warning is logged if no scripts are found after filtering out any files without such an extension. I added some unit tests for this case too.

[devlead]

@gitfool your changes have been merged, thanks for your contribution 👍