GH2424: Adds /sm argument to SignTool #2372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devlead
approved these changes
Jan 1, 2019
There was a problem hiding this comment.
This looks good to me, however was in violation with our Contribution Guidelines this targets our main and not develop branch, there's also no issue to go along with this PR also required per our guidelines.
In this case I've done the work to add the issue #2424 and retarget PR against develop, cherry-picked and rebased against latest develop to be able to review PR properly so won't request changes this time.
|
@MihaMarkic your changes have been merged, thanks for your contribution 👍 |
gep13
changed the title
|
Ah, right, sorry guys, I should have read the guidelines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.