Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] GH2028: adding credential support for inprocess nuget client (please don't merge) #2090

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Insire
Copy link
Contributor

@Insire Insire commented Mar 17, 2018

added NuGet.Credentials package,
added WIP call to PluginCredentialProviderBuilder

relates to #2028

added WIP call to PluginCredentialProviderBuilder
Copy link
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Insire there's a conflict with this PR and develop that needs to be resolved before this PR can be reviewed.

@axdiamond
Copy link

@Insire do you intend to finish this PR?

@Insire
Copy link
Contributor Author

Insire commented Jul 3, 2018

RL is rather busy for me at the moment, so if anyone wants to take over, go ahead.

@gep13 gep13 changed the title WIP adding credential support for inprocess nuget client (please don't merge) [WIP] GH2028: adding credential support for inprocess nuget client (please don't merge) Jul 25, 2018
@bjorkstromm bjorkstromm self-assigned this Mar 21, 2019
@bjorkstromm
Copy link
Member

@Insire I'll take over at some point. Talked to NuGet team today, and we should dig into the plugin system for authentication.

@Insire
Copy link
Contributor Author

Insire commented Mar 21, 2019

Sounds good.

@augustoproiete augustoproiete marked this pull request as draft February 27, 2021 23:32
@gep13
Copy link
Member

gep13 commented May 15, 2022

@bjorkstromm can you elaborate on this comment:

Talked to NuGet team today, and we should dig into the plugin system for authentication.

Is there something specific that we should be looking at here? If so, can you point us in the right direction? Or perhaps update the original issue with your thoughts on this?

Is this something that should be left to say the "NuGet Authenticate" task in Azure DevOps (https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/package/nuget-authenticate?view=azure-devops) rather than something that should be brought into Cake?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants