Register connection if connection_config is included ModuleConfig #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mynhardt Burger <[email protected]>
mynhardtburger
commented
Jun 5, 2024
| @@ -178,6 +190,7 @@ def save(self, model_path: str): | |||
| "prompt_cache_id": self._prompt_cache_id, | |||
| "eos_token": self.eos_token, | |||
| "verbalizer": self.verbalizer, | |||
| # TODO: Add connection_config | |||
There was a problem hiding this comment.
Should the save() method not also save the existing connection_config for future use?
mynhardtburger
commented
Jun 5, 2024
| @@ -203,6 +217,7 @@ def save(self, model_path: str): | |||
| "sep_token": self._sep_token, | |||
| "eos_token": self._eos_token, | |||
| "pad_token": self._pad_token, | |||
| # TODO: Add connection_config | |||
There was a problem hiding this comment.
Should the save() method not also save the existing connection_config for future use?
mynhardtburger
commented
Jun 5, 2024
| @@ -141,6 +147,7 @@ def bootstrap(cls, model_path: str, load_backend: Union[BackendBase, None] = Non | |||
| eos_token=eos_token, | |||
| pad_token=pad_token, | |||
| tgis_backend=load_backend, | |||
| # TODO: Add connection_config? | |||
There was a problem hiding this comment.
When bootstrapping should the connection_config also be populated?
mynhardtburger
commented
Jun 5, 2024
| @@ -142,6 +149,10 @@ def load(cls, model_path: str, load_backend: BackendBase) -> "PeftPromptTuningTG | |||
| log.debug("Prompt ID: %s", prompt_cache_id) | |||
| log.debug("TGIS model ID: %s", base_model_name) | |||
|
|
|||
| # connection_config is a dict with all the necessary fields to successfully create | |||
| # a TGISConnection using the .from_config() method. | |||
There was a problem hiding this comment.
The connection config will roughly look like this:
connection_config:
hostname:
model_id:
namespace:
ca_cert_file:
client_cert_file:
client_key_file:
prompt_dir:
grpc_lb_policy_name:
grpc_lb_poll_interval_s:
hostname_override: 
|
@gabe-l-hart FYI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.