Fix SRD0024 issues

cagrin · Mar 15, 2024 · 91dd88b · 91dd88b
1 parent cdd3902
commit 91dd88b
Show file tree

Hide file tree

Showing 8 changed files with 9 additions and 10 deletions.
diff --git a/latest/SqlCodeAnalysisRules.props b/latest/SqlCodeAnalysisRules.props
@@ -7,7 +7,6 @@
         <CodeAnalysisRules>-SqlServer.Rules.SRD0013; $(CodeAnalysisRules)</CodeAnalysisRules>
         <CodeAnalysisRules>-SqlServer.Rules.SRD0015; $(CodeAnalysisRules)</CodeAnalysisRules>
         <CodeAnalysisRules>-SqlServer.Rules.SRD0017; $(CodeAnalysisRules)</CodeAnalysisRules>
-        <CodeAnalysisRules>-SqlServer.Rules.SRD0024; $(CodeAnalysisRules)</CodeAnalysisRules>
         <CodeAnalysisRules>-SqlServer.Rules.SRD0026; $(CodeAnalysisRules)</CodeAnalysisRules>
         <CodeAnalysisRules>-SqlServer.Rules.SRD0032; $(CodeAnalysisRules)</CodeAnalysisRules>
         <CodeAnalysisRules>-SqlServer.Rules.SRD0043; $(CodeAnalysisRules)</CodeAnalysisRules>

diff --git a/latest/tSQLt.Edge/Internal/tSQLt.Internal_ApplyIndex.sql b/latest/tSQLt.Edge/Internal/tSQLt.Internal_ApplyIndex.sql
@@ -47,7 +47,7 @@ BEGIN
             'CREATE', @IndexUnique, @IndexType, 'INDEX', @IndexName, 'ON', @ObjectName, @IndexDefinition
         )
 
-        EXEC (@CreateIndex);
+        EXEC sys.sp_executesql @CreateIndex;
     END
     ELSE
     BEGIN

diff --git a/latest/tSQLt.Edge/Internal/tSQLt.Internal_FakeTable.sql b/latest/tSQLt.Edge/Internal/tSQLt.Internal_FakeTable.sql
@@ -24,7 +24,7 @@ BEGIN
     DECLARE @NewTableName NVARCHAR(MAX);
     EXEC tSQLt.Private_RenameObject @TableName, @NewTableName OUTPUT;
 
-    EXEC (@CreateFakeTableCommand);
+    EXEC sys.sp_executesql @CreateFakeTableCommand;
 
     DECLARE @NewObjectId INT = OBJECT_ID(@TableName);
     INSERT INTO tSQLt.Private_FakeTables (ObjectId, ObjectName, FakeObjectId, FakeObjectName)

diff --git a/latest/tSQLt.Edge/Private/tSQLt.Private_ApplyCheckConstraint.sql b/latest/tSQLt.Edge/Private/tSQLt.Private_ApplyCheckConstraint.sql
@@ -21,6 +21,6 @@ BEGIN
         'ALTER TABLE', @ObjectName, 'ADD CONSTRAINT',  @ConstraintName, 'CHECK', @ConstraintDefinition
     )
 
-    EXEC (@CreateConstraint);
+    EXEC sys.sp_executesql @CreateConstraint;
 END;
 GO
diff --git a/latest/tSQLt.Edge/Private/tSQLt.Private_ApplyForeignKey.sql b/latest/tSQLt.Edge/Private/tSQLt.Private_ApplyForeignKey.sql
@@ -41,7 +41,7 @@ BEGIN
         'ALTER TABLE', @ObjectName, 'ADD CONSTRAINT',  @ConstraintName, 'FOREIGN KEY', @ConstraintDefinition
     )
 
-    EXEC (@CreateUniqueIndex);
-    EXEC (@CreateForeignKey);
+    EXEC sys.sp_executesql @CreateUniqueIndex;
+    EXEC sys.sp_executesql @CreateForeignKey;
 END;
 GO
diff --git a/latest/tSQLt.Edge/Private/tSQLt.Private_ApplyPrimaryKey.sql b/latest/tSQLt.Edge/Private/tSQLt.Private_ApplyPrimaryKey.sql
@@ -139,7 +139,7 @@ BEGIN
         'ALTER TABLE', @ObjectName, 'ADD CONSTRAINT',  @ConstraintName, 'PRIMARY KEY', @ConstraintDefinition
     )
 
-    EXEC (@AlterPrimaryColumns);
-    EXEC (@CreatePrimaryKey);
+    EXEC sys.sp_executesql @AlterPrimaryColumns;
+    EXEC sys.sp_executesql @CreatePrimaryKey;
 END;
 GO
diff --git a/latest/tSQLt.Edge/Private/tSQLt.Private_ApplyUniqueConstraint.sql b/latest/tSQLt.Edge/Private/tSQLt.Private_ApplyUniqueConstraint.sql
@@ -33,6 +33,6 @@ BEGIN
         'ALTER TABLE', @ObjectName, 'ADD CONSTRAINT',  @ConstraintName, 'UNIQUE', @ConstraintDefinition
     )
 
-    EXEC (@CreateUniqueConstraint);
+    EXEC sys.sp_executesql @CreateUniqueConstraint;
 END;
 GO
diff --git a/latest/tSQLt.Edge/Private/tSQLt.Private_RenameObject.sql b/latest/tSQLt.Edge/Private/tSQLt.Private_RenameObject.sql
@@ -27,6 +27,6 @@ BEGIN
         QUOTENAME(@NewName)
     );
 
-    EXEC (@Command);
+    EXEC sys.sp_executesql @Command;
 END;
 GO
-Original file line number
+Diff line change
@@ Expand Up / @@ -47,7 +47,7 @@ BEGIN @@
                 'CREATE', @IndexUnique, @IndexType, 'INDEX', @IndexName, 'ON', @ObjectName, @IndexDefinition
             )
-            EXEC (@CreateIndex);
+            EXEC sys.sp_executesql @CreateIndex;
         END
         ELSE
         BEGIN
@@ Expand Down @@