Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs build update to address #24 #36

Merged
merged 5 commits into from
Aug 22, 2024
Merged

docs build update to address #24 #36

merged 5 commits into from
Aug 22, 2024

Conversation

britt-allen
Copy link
Contributor

@britt-allen britt-allen commented Aug 21, 2024

fixes #24 and fixes #35

@britt-allen britt-allen self-assigned this Aug 21, 2024
@britt-allen
Copy link
Contributor Author

unclear what exactly is failing. any ideas @JamesSLogan @tnrahim ??

@JamesSLogan
Copy link
Collaborator

It looks like during the tests.sh invocation, the script fails when running pre-commit, specifically due to sqlfluff failing to start up. Here's the error message:
ImportError: cannot import name 'read_user_config' from 'dbt.config'

Potentially relevant packages from poetry output:

  - Installing dbt-core (1.6.18)
  - Installing sqlfluff (2.3.0)
  - Installing sqlfluff-templater-dbt (2.3.0)

Based on this issue: sqlfluff/sqlfluff#5841, dbt-core introduced an incompatibility with sqlfluff recent-ishly, and this incompatibility was backported to dbt-core 1.6.14.

To solve this issue for our case, I think we'd want to bring sqlfluff up-to-date (rather than lock dbt-core in a lower version). Here's to hoping there aren't cascading issues after upgrading sqlfluff...

@britt-allen
Copy link
Contributor Author

I am getting a dbt error now. I tried to run a poetry.lock update locally, but it seems this project has no poetry.lock file and I am not sure why

@britt-allen britt-allen merged commit a038573 into main Aug 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move profile config to avoid deprecation warning Build docs on PRs
2 participants