Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "use alpine version" #5

Merged
merged 1 commit into from
Jul 10, 2020
Merged

Revert "use alpine version" #5

merged 1 commit into from
Jul 10, 2020

Conversation

ftnet
Copy link
Contributor

@ftnet ftnet commented Feb 26, 2020

Reverts #2

@CvX
Copy link

CvX commented Mar 21, 2020

To clarify, non-alpine base image is required because:

  1. It's a common pattern to use git ls-files in gemspec. Alpine doesn't contain git by default.
  2. Bundler might fail to install some unusual binary dependencies on alpine.

cadwallion
cadwallion approved these changes Jul 10, 2020
View reviewed changes
Copy link
Owner

@cadwallion cadwallion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay on this. I'll merge then update from 2.6.0 -> 2.6.10 in a separate PR.

@cadwallion cadwallion merged commit 6348c36 into cadwallion:master Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cadwallion cadwallion cadwallion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ftnet @CvX @cadwallion