Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ring member refresh log improvements #6361

Conversation

taylanisikdemir
Copy link
Contributor

What changed?
The refreshed ring members log is useful for troubleshooting membership change related issues. However it lacks a few things:

  • count of members as separate log tag
  • sorted member list to easily export/diff logs
  • the service name that the ring belongs to.

How did you test it?
CI checks

@taylanisikdemir taylanisikdemir merged commit 6d16588 into cadence-workflow:master Oct 15, 2024
18 checks passed
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.57%. Comparing base (084464e) to head (59b8c2e).
Report is 1 commits behind head on master.

Additional details and impacted files
Files with missing lines Coverage Δ
common/membership/hashring.go 91.05% <100.00%> (+0.09%) ⬆️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 084464e...59b8c2e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants