Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parent close policy #6307

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Fix parent close policy #6307

merged 1 commit into from
Sep 26, 2024

Conversation

Shaddoll
Copy link
Contributor

What changed?
Split large number of child workflows into small batches to apply parent close policy

Why?
To avoid hitting the blob size limit of signal with start workflow API

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.20%. Comparing base (16c5e64) to head (6e49baa).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...vice/history/task/transfer_active_task_executor.go 85.71% 1 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...vice/history/task/transfer_active_task_executor.go 67.37% <85.71%> (+0.14%) ⬆️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16c5e64...6e49baa. Read the comment docs.

@Shaddoll Shaddoll merged commit 71cf16a into cadence-workflow:master Sep 26, 2024
20 checks passed
@Shaddoll Shaddoll deleted the parent branch September 26, 2024 03:33
dkrotx pushed a commit to dkrotx/cadence that referenced this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants