Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wf-Diagnostics] emit metrics from diagnostics workflow #6299

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

sankari165
Copy link
Contributor

What changed?
metrics emitted from diagnostics workflow

Why?
to monitor the workflow execution time and success rate

How did you test it?

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.20%. Comparing base (c8abc2a) to head (c266fb4).
Report is 2 commits behind head on master.

Additional details and impacted files
Files with missing lines Coverage Δ
service/worker/diagnostics/workflow.go 81.51% <100.00%> (+0.81%) ⬆️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8abc2a...c266fb4. Read the comment docs.

common/metrics/defs.go Outdated Show resolved Hide resolved
@sankari165 sankari165 enabled auto-merge (squash) September 24, 2024 07:43
@sankari165 sankari165 merged commit 11c3626 into cadence-workflow:master Sep 24, 2024
19 of 20 checks passed
@sankari165 sankari165 deleted the CDNC-10488 branch September 24, 2024 08:50
dkrotx pushed a commit to dkrotx/cadence that referenced this pull request Sep 26, 2024
…flow#6299)

* [Wf-Diagnostics] emit metrics from diagnostics workflow

* Update workflow.go

* address comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants