Add canary jitter workflow debugging log #6278
Conversation
bowenxia
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
bowenxia
changed the title
bowenxia
changed the title
| wh.GetLogger().Debug("Start workflow execution request domainID", | ||
| tag.WorkflowDomainID(domainID), | ||
| tag.WorkflowID(startRequest.WorkflowID), | ||
| tag.Dynamic("JitterStartSeconds", jitterStartSeconds), | ||
| tag.Dynamic("firstDecisionTaskBackoffSeconds", historyRequest.GetFirstDecisionTaskBackoffSeconds()), | ||
| ) |
There was a problem hiding this comment.
is it possible to cover these in tests ?
There was a problem hiding this comment.
@bowenxia I wonder if you need to have this permanently or just for debugging.
If it's purely for debugging (I guess so since tags are too specific) then you can temporarily deploy your own branch.
There was a problem hiding this comment.
As I talked about this in Cadence all hands, this kind of error happens randomly. It had been happened in Prod07, Prod04, Prod12 etc. I can't predict which environment will have that error, so I'll have to merge it to main and turn on the debug mode once this is once happen in the future. :(
What changed?
Why?
How did you test it?
Potential risks
Release notes
Documentation Changes