Minor metrics / log improvement for global ratelimiter #6259
Conversation
Ran into some issues building a dashboard with these, as "worker_domain_name" does not automatically relate to "domain-name", and addressing that is... sadly difficult in our monitoring systems. Regardless, I think using local keys is probably better. We already have the collection name in logs and metrics, and this way you can search for the domain name and find all of these at once (easier for browsing randomly) and it's no harder to narrow down either (just also search by collection).
Groxx
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| func GlobalRatelimiterKeyTag(value string) Tag { | ||
| return simpleMetric{key: globalRatelimitKey, value: sanitizer.Value(value)} |
There was a problem hiding this comment.
not sure I understand the problem with the tag, sorry? is it just that this makes joining with other metrics using domain_name hard?
There was a problem hiding this comment.
to pull from (and paraphrase) chat:
I'm trying to build this data into our client dashboard, where we have a
$domainvariable withdomain-namein it, which is used for all of our other domain-related queries.
Right now this is emittingcollection_name_domain_name, which needs pretty complex rewrites / set intersections / etc to correlate with thedomain-namevalue. Possible, but a bit absurd.
|
discussed offline: tl;dr yes to my question |
Ran into some issues building a dashboard with these, as the collecton's
worker_domain_namevalue does not automatically relate to everything else'sdomain-namevalue, and addressing that is... sadly difficult in our monitoring systems.Regardless, I think using local keys is probably better. We already have the collection name in logs and metrics, and this way you can search for the domain name and find all of these at once (easier for browsing randomly) and it's no harder to narrow down either (just also search by collection).