Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for the stray lines needing coverage. #6098

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

agautam478
Copy link
Contributor

What changed?
Added some extra test cases to increase coverage for some stray lines that were missed in previous PRs.

Why?
code coverage

How did you test it?

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.08%. Comparing base (ab0d875) to head (723c0ec).
Report is 8 commits behind head on master.

Additional details and impacted files

see 19 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab0d875...723c0ec. Read the comment docs.

@agautam478 agautam478 changed the title Final tests Tests for the stray lines needing coverage. Jun 4, 2024
@agautam478 agautam478 enabled auto-merge (squash) June 4, 2024 21:33
@coveralls
Copy link

coveralls commented Jun 4, 2024

Pull Request Test Coverage Report for Build 018fe51b-e6eb-4b35-9fd1-9ff51a8e73b0

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 766 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-0.4%) to 70.211%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 88.06%
common/task/fifo_task_scheduler.go 2 85.57%
service/matching/tasklist/matcher.go 2 89.35%
service/matching/tasklist/task_reader.go 2 77.72%
common/persistence/historyManager.go 2 66.67%
service/history/handler/handler.go 3 96.2%
service/history/engine/engineimpl/reset_sticky_tasklist.go 6 66.67%
service/history/engine/engineimpl/poll_mutable_state.go 9 74.16%
service/frontend/api/handler.go 24 65.45%
service/history/shard/context.go 52 69.17%
Totals Coverage Status
Change from base Build 018fe4fa-880c-4efc-b964-4cf1474664a6: -0.4%
Covered Lines: 104579
Relevant Lines: 148950

💛 - Coveralls

@agautam478 agautam478 merged commit 65cbc8e into cadence-workflow:master Jun 4, 2024
20 checks passed
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 4, 2024
* Covering the stray lines in various files

* One more test case

* One more test case
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 4, 2024
* Covering the stray lines in various files

* One more test case

* One more test case
dkrotx pushed a commit to dkrotx/cadence that referenced this pull request Jun 5, 2024
* Covering the stray lines in various files

* One more test case

* One more test case
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
* Covering the stray lines in various files

* One more test case

* One more test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants