Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using find instead of ** to locate Dockerfiles #6096

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

dkrotx
Copy link
Contributor

@dkrotx dkrotx commented Jun 4, 2024

./scripts/check-go-toolchain.sh recently started to use shopt globstar which is not always awailable in MacOS' old Bash

Fixing build on some laptops

The change' syntax should be recognized by early Bash versions
Just launched ./scripts/check-go-toolchain.sh

Potential risks

Release notes

Documentation Changes

Copy link
Contributor

@Groxx Groxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't run it right now, but yup - looks correct :)
Sorry about that, I apparently have my bash upgraded locally.

@dkrotx dkrotx enabled auto-merge (squash) June 4, 2024 19:23
@dkrotx dkrotx merged commit cd8c132 into cadence-workflow:master Jun 4, 2024
17 of 18 checks passed
@coveralls
Copy link

coveralls commented Jun 4, 2024

Pull Request Test Coverage Report for Build 018fe4b0-a62c-4461-9a5b-807ba0e03a69

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 77 unchanged lines in 16 files lost coverage.
  • Overall coverage decreased (-0.02%) to 70.174%

Files with Coverage Reduction New Missed Lines %
service/history/queue/timer_queue_processor_base.go 1 78.28%
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
service/matching/tasklist/db.go 2 73.23%
common/task/fifo_task_scheduler.go 2 87.63%
service/matching/tasklist/task_writer.go 2 82.32%
service/history/execution/mutable_state_util.go 2 78.52%
common/log/tag/tags.go 3 50.46%
common/persistence/nosql/nosql_task_store.go 3 85.52%
service/history/task/fetcher.go 3 85.57%
common/types/history.go 4 45.35%
Totals Coverage Status
Change from base Build 018fe451-cd64-44f5-8cb8-8b9c6b71f4ba: -0.02%
Covered Lines: 104524
Relevant Lines: 148950

💛 - Coveralls

timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 4, 2024
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 4, 2024
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants