Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate unit tests from AWS to GKE #6082

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Migrate unit tests from AWS to GKE #6082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 33 additions & 5 deletions .buildkite/pipeline-master.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,18 +37,26 @@ steps:
command: "./scripts/buildkite/fossa.sh"

- label: ":golang: unit test"
agents:
queue: "workers"
commands:
- "CASSANDRA_HOST=cassandra make install-schema && make cover_profile" # make install-schema is needed for a server startup test. See main_test.go
- "./scripts/buildkite/gen_coverage_metadata.sh .build/coverage/metadata.txt"
artifact_paths:
- ".build/coverage/*.out"
- ".build/coverage/metadata.txt"
retry:
automatic:
limit: 1
plugins:
- kubernetes:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was expecting this change to cause unit test to time out because it was consistently failing during initial migration. I guess some recent changes improved the matching folder's test duration

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some improvements on the matching tests last Friday.

<<: *kubernetes
podSpec:
<<: *podSpec
containers:
- <<: *commandContainer
command:
- |-
# ensure that we are not rebuilding binaries and not regenerating code
make .just-build
# make install-schema is needed for a server startup test. See main_test.go
CASSANDRA_HOST=cassandra make install-schema && make cover_profile
./scripts/buildkite/gen_coverage_metadata.sh .build/coverage/metadata.txt
- docker-compose#v3.0.0:
run: unit-test
config: docker/buildkite/docker-compose.yml
Expand Down Expand Up @@ -112,6 +120,26 @@ steps:
run: integration-test-cassandra
config: docker/buildkite/docker-compose-es7.yml

- label: ":golang: integration test with cassandra with OpenSearch v2"
artifact_paths:
- ".build/coverage/*.out"
retry:
automatic:
limit: 1
plugins:
- kubernetes:
<<: *kubernetes
podSpec:
<<: *podSpec
containers:
- <<: *commandContainer
command:
- |-
make cover_integration_profile
- docker-compose#v3.0.0:
run: integration-test-cassandra
config: docker/buildkite/docker-compose-opensearch2.yml

- label: ":golang: integration ndc test with cassandra"
artifact_paths:
- ".build/coverage/*.out"
Expand Down
19 changes: 13 additions & 6 deletions .buildkite/pipeline-pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,19 +37,26 @@ steps:
command: "./scripts/buildkite/fossa.sh"

- label: ":golang: unit test"
agents:
queue: "workers"
commands:
- "make .just-build" # ensure that we are not rebuilding binaries and not regenerating code
- "CASSANDRA_HOST=cassandra make install-schema && make cover_profile" # make install-schema is needed for a server startup test. See main_test.go
- "./scripts/buildkite/gen_coverage_metadata.sh .build/coverage/metadata.txt"
artifact_paths:
- ".build/coverage/*.out"
- ".build/coverage/metadata.txt"
retry:
automatic:
limit: 1
plugins:
- kubernetes:
<<: *kubernetes
podSpec:
<<: *podSpec
containers:
- <<: *commandContainer
command:
- |-
# ensure that we are not rebuilding binaries and not regenerating code
make .just-build
# make install-schema is needed for a server startup test. See main_test.go
CASSANDRA_HOST=cassandra make install-schema && make cover_profile
./scripts/buildkite/gen_coverage_metadata.sh .build/coverage/metadata.txt
- docker-compose#v3.0.0:
run: unit-test
config: docker/buildkite/docker-compose.yml
Expand Down
Loading