Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unit tests for service/history/handler #5970

Merged
merged 7 commits into from
May 7, 2024

Conversation

timl3136
Copy link
Contributor

@timl3136 timl3136 commented May 6, 2024

What changed?
Added more unit tests for methods in history/hander.go

Why?
Increase test coverage and stability

How did you test it?
Unit tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.10%. Comparing base (2ac145f) to head (03fe5ef).

Additional details and impacted files

see 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ac145f...03fe5ef. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018f547c-082a-459c-9a5d-7c1b345bc34b

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 48 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.09%) to 68.211%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 1 89.05%
service/history/queue/timer_queue_processor_base.go 1 77.66%
common/task/parallel_task_processor.go 2 93.06%
service/matching/taskListManager.go 2 80.65%
service/history/task/fetcher.go 3 86.6%
common/task/fifo_task_scheduler.go 4 85.57%
service/history/execution/mutable_state_task_refresher.go 15 62.03%
service/history/task/task_util.go 20 70.57%
Totals Coverage Status
Change from base Build 018f5467-b337-442d-bcf0-8ad761c213c7: 0.09%
Covered Lines: 100196
Relevant Lines: 146892

💛 - Coveralls

@timl3136 timl3136 enabled auto-merge (squash) May 7, 2024 19:58
@timl3136 timl3136 merged commit abfa99b into cadence-workflow:master May 7, 2024
20 checks passed
@timl3136 timl3136 deleted the handler-test-4 branch May 7, 2024 20:37
abhishekj720 pushed a commit to abhishekj720/cadence that referenced this pull request May 7, 2024
abhishekj720 pushed a commit to abhishekj720/cadence that referenced this pull request May 7, 2024
agautam478 pushed a commit to agautam478/cadence that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants