-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added unit tests for service/history/handler #5970
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timl3136
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
May 6, 2024 21:05
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Pull Request Test Coverage Report for Build 018f547c-082a-459c-9a5d-7c1b345bc34bDetails
💛 - Coveralls |
taylanisikdemir
approved these changes
May 7, 2024
abhishekj720
pushed a commit
to abhishekj720/cadence
that referenced
this pull request
May 7, 2024
* Added unit tests for history handler
abhishekj720
pushed a commit
to abhishekj720/cadence
that referenced
this pull request
May 7, 2024
* Added unit tests for history handler
agautam478
pushed a commit
to agautam478/cadence
that referenced
this pull request
May 8, 2024
* Added unit tests for history handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added more unit tests for methods in history/hander.go
Why?
Increase test coverage and stability
How did you test it?
Unit tests
Potential risks
Release notes
Documentation Changes