Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-coverage] Add tests for HandleDecisionTaskScheduled API in service/history/decision #5901

Merged

Conversation

ketsiambaku
Copy link
Contributor

@ketsiambaku ketsiambaku commented Apr 10, 2024

What changed?
Add tests for HandleDecisionTaskScheduled API in service/history/decision

Why?
Code coverage improvements

How did you test it?
unit tests

Potential risks
N/A

Release notes

Documentation Changes

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Merging #5901 (95c28bc) into master (e833741) will increase coverage by 0.05%.
The diff coverage is n/a.

Additional details and impacted files

see 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e833741...95c28bc. Read the comment docs.

@ketsiambaku ketsiambaku changed the title Add tests for HandleDecisionTaskScheduled API [code-coverage] Add tests for HandleDecisionTaskScheduled API in service/history/decision Apr 10, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018ec872-14c0-407b-b9b9-95663192c075

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 46 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.02%) to 67.372%

Files with Coverage Reduction New Missed Lines %
service/matching/taskReader.go 2 84.88%
service/matching/matcher.go 2 90.72%
service/history/queue/timer_queue_processor_base.go 3 77.82%
service/history/task/fetcher.go 3 86.6%
common/task/fifo_task_scheduler.go 4 83.51%
service/history/execution/mutable_state_task_refresher.go 32 56.65%
Totals Coverage Status
Change from base Build 018ec712-a05e-4ec1-a66b-6d12d6428fe1: 0.02%
Covered Lines: 98212
Relevant Lines: 145776

💛 - Coveralls

@ketsiambaku ketsiambaku merged commit 7b4b90e into cadence-workflow:master Apr 10, 2024
20 checks passed
@ketsiambaku ketsiambaku deleted the history-decision-handler branch April 14, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants