Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more unit test to history handler #5897

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

timl3136
Copy link
Contributor

@timl3136 timl3136 commented Apr 9, 2024

What changed?
Add more unit test to history handler

Why?
Improve test coverage and stability

How did you test it?
Unit test

Potential risks

Release notes

Documentation Changes

@timl3136 timl3136 enabled auto-merge (squash) April 9, 2024 22:04
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Merging #5897 (f085760) into master (1c7d522) will decrease coverage by 0.45%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head f085760 differs from pull request most recent head d6ee70f. Consider uploading reports for the commit d6ee70f to get more accurate results

Additional details and impacted files

see 41 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cd0f80...d6ee70f. Read the comment docs.

@timl3136 timl3136 merged commit e98ce90 into cadence-workflow:master Apr 18, 2024
18 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018ef24a-037e-41b5-91cc-d62eaaa270cf

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 45 unchanged lines in 11 files lost coverage.
  • Overall coverage increased (+0.03%) to 67.585%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
service/matching/taskListManager.go 2 80.46%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
service/history/queue/timer_queue_processor_base.go 3 77.82%
service/history/queue/timer_gate.go 3 95.83%
common/persistence/statsComputer.go 3 96.79%
service/history/task/transfer_standby_task_executor.go 4 86.6%
common/persistence/nosql/nosql_task_store.go 5 61.95%
common/task/fifo_task_scheduler.go 5 84.54%
Totals Coverage Status
Change from base Build 018eeeee-9517-449e-b456-d07d85466364: 0.03%
Covered Lines: 98928
Relevant Lines: 146376

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants