Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Covered the missed lines in the nosql_execution_utils.go #5871

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

agautam478
Copy link
Contributor

What changed?
Added more test cases for the missed lines in the utils file. We are somewhere around 80% coverage now.
I will cover the pending 20% in the next diff.

Why?
code coverage week.

How did you test it?

Potential risks

Release notes

Documentation Changes

@agautam478 agautam478 enabled auto-merge (squash) April 4, 2024 23:12
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Merging #5871 (eb468e7) into master (e040206) will increase coverage by 0.03%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head eb468e7 differs from pull request most recent head f707135. Consider uploading reports for the commit f707135 to get more accurate results

Additional details and impacted files

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf0f9a5...f707135. Read the comment docs.

@agautam478 agautam478 merged commit 9af0e32 into cadence-workflow:master Apr 4, 2024
18 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018eab78-e925-43ea-8852-2b3f87ced846

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 55 unchanged lines in 12 files lost coverage.
  • Overall coverage increased (+0.009%) to 66.35%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
common/task/fifo_task_scheduler.go 2 85.57%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
service/matching/db.go 2 73.23%
service/matching/taskListManager.go 2 79.7%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
common/log/tag/tags.go 3 50.18%
service/history/queue/timer_queue_processor_base.go 3 77.62%
service/matching/taskReader.go 5 84.08%
common/persistence/nosql/nosql_task_store.go 5 61.95%
Totals Coverage Status
Change from base Build 018eab74-1b97-430d-8296-bb357d4b46eb: 0.009%
Covered Lines: 97103
Relevant Lines: 146349

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants