Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests for cassandra/queue.go #5845

Merged

Conversation

taylanisikdemir
Copy link
Contributor

What changed?
Adding tests for cassandra/queue.go

Why?
Improve coverage.

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Merging #5845 (be394ff) into master (24cd976) will increase coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head be394ff differs from pull request most recent head c1ee917. Consider uploading reports for the commit c1ee917 to get more accurate results

Additional details and impacted files
Files Coverage Δ
...n/persistence/nosql/nosqlplugin/cassandra/queue.go 100.00% <100.00%> (+100.00%) ⬆️

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24cd976...c1ee917. Read the comment docs.

@coveralls
Copy link

coveralls commented Apr 3, 2024

Pull Request Test Coverage Report for Build 018ea4e2-f269-4fa8-b611-3902fe14d37f

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 35 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.1%) to 65.994%

Files with Coverage Reduction New Missed Lines %
service/matching/taskReader.go 2 84.88%
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
common/task/fifo_task_scheduler.go 2 87.63%
tools/cli/admin_db_decode_thrift.go 2 70.51%
common/persistence/historyManager.go 2 66.67%
common/persistence/nosql/nosql_task_store.go 5 61.95%
service/history/task/transfer_standby_task_executor.go 8 87.01%
common/persistence/nosql/nosqlplugin/cassandra/gocql/public/client.go 12 20.93%
Totals Coverage Status
Change from base Build 018ea4e2-60e3-4f73-9198-fb325674c74f: 0.1%
Covered Lines: 96574
Relevant Lines: 146337

💛 - Coveralls

@taylanisikdemir taylanisikdemir merged commit c573c9c into cadence-workflow:master Apr 3, 2024
18 checks passed
@taylanisikdemir taylanisikdemir deleted the taylan/queue_tests branch April 3, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants