-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[common/persistence] Add ExecutionManager tests #5803
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stamped with 2 comments
This reverts commit 71c7fd5.
Codecov Report
Additional details and impacted files
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Pull Request Test Coverage Report for Build 018e60e6-74a5-4e89-90ce-79a84a394cc6Details
💛 - Coveralls |
What changed?
I've introduced tests for proxy methods in persistence/ExecutionManager type.
To achive it I've created mocks for ExecutionStore and PayloadSerializer so that unit tests can focus only on manager logic.
As a first step I only test proxy methods that do not provide any logic. I'll follow up with a PR that focuses on more complex methods.
Why?
To increase code coverage and code quality.
How did you test it?
unit tests
Potential risks
None
Release notes
Documentation Changes