Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable kafka consumer test #5791

Conversation

taylanisikdemir
Copy link
Contributor

What changed?
TestNewConsumer was flaky so it was disabled recently. Underlying issues are addressed in #5712 so re-enabling it.

How did you test it?
go test -timeout 60s -run ^TestNewConsumer$ github.com/uber/cadence/common/messaging/kafka -v -count=100

@taylanisikdemir taylanisikdemir enabled auto-merge (squash) March 15, 2024 18:35
@taylanisikdemir taylanisikdemir merged commit 9cd9109 into cadence-workflow:master Mar 15, 2024
17 of 18 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018e4358-d6b0-4512-a8bb-f92b4086fdec

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 67 unchanged lines in 11 files lost coverage.
  • Overall coverage increased (+0.009%) to 64.883%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 1 89.05%
service/history/task/timer_task_executor_base.go 2 78.38%
service/history/execution/mutable_state_util.go 2 78.48%
common/task/fifo_task_scheduler.go 3 84.54%
tools/cli/admin_db_decode_thrift.go 3 69.23%
service/history/queue/timer_gate.go 3 95.83%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 3 71.41%
service/history/task/fetcher.go 4 86.08%
service/history/task/transfer_standby_task_executor.go 6 86.6%
common/persistence/nosql/nosqlplugin/cassandra/workflow_parsing_utils.go 19 79.13%
Totals Coverage Status
Change from base Build 018e415e-6c2b-4c47-90b3-66581a8de24f: 0.009%
Covered Lines: 94584
Relevant Lines: 145777

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants