-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor common/persistence/pinot tests #5777
refactor common/persistence/pinot tests #5777
Conversation
|
||
if test.expectedError != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea moving the setup to table items to make it more declarative
Codecov Report
Additional details and impacted filessee 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Pull Request Test Coverage Report for Build 018e2fc5-923b-4ae3-9939-51f10add70e1Details
💛 - Coveralls |
What changed?
Refactored test code in common/persistence/pinot
Why?
follow the best practice
How did you test it?
unit test
Potential risks
Release notes
Documentation Changes