[code-coverage] Generate code for matching client timeout wrapper #5771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ketsiambaku
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Codecov Report
Additional details and impacted files
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Pull Request Test Coverage Report for Build 018e386e-4182-46f8-8d17-ce0c00d33dacDetails
💛 - Coveralls |
Shaddoll
reviewed
Mar 11, 2024
client/templates/timeout.tmpl
Outdated
| @@ -70,3 +118,54 @@ func (c * {{$decorator}}) {{$method.Declaration}} { | |||
| {{$method.Pass ("c.client.") }} | |||
| } | |||
| {{end}} | |||
| {{end}} | |||
|
|
|||
| {{/* ↓↓↓ Special Case APIs ↓↓↓ */}} | |||
There was a problem hiding this comment.
I suggest moving special case APIs out of generated code.
There was a problem hiding this comment.
Done. I left it in the current file and only took out the timeout logic
This reverts commit fa3207683ca8777d9a28984033e3931d00b2e342.
ketsiambaku
force-pushed
the
gowrap-timeout-client
branch
from
1432c0c
to
580c1de
Compare
Shaddoll
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Update timeout template to Generate code in client/matching/client.go with gowrap
Why?
To reduce manual work when adding APIs
Improve code coverage
How did you test it?
unit tests
Potential risks
Release notes
Documentation Changes