Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More unit tests for nosql_execution_store_test.go #5753

Merged
merged 5 commits into from
Mar 8, 2024

Conversation

agautam478
Copy link
Contributor

What changed?
Added tests for the following:
GetReplicationTasks, CompleteTransferTask, RangeCompleteTransferTask, and CompleteCrossClusterTask.

All the functions contain one success and one failure case in order to cover the man methods in the file.

Why?
To increase code coverage.

How did you test it?
unit test

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Merging #5753 (5050592) into master (b223d42) will increase coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head 5050592 differs from pull request most recent head c05e856. Consider uploading reports for the commit c05e856 to get more accurate results

Additional details and impacted files

see 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c1eba8...c05e856. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 7, 2024

Pull Request Test Coverage Report for Build 018e1b90-9a76-4e20-8892-91b7523281e6

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 62 unchanged lines in 13 files lost coverage.
  • Overall coverage increased (+0.008%) to 63.384%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
common/persistence/sql/sqlplugin/postgres/task.go 2 73.4%
common/persistence/sql/sqlplugin/postgres/db.go 2 80.0%
service/matching/db.go 2 73.23%
service/matching/taskListManager.go 2 79.7%
common/persistence/historyManager.go 2 66.67%
common/persistence/sql/common.go 2 46.75%
common/persistence/sql/sql_task_store.go 2 54.32%
service/matching/matcher.go 2 90.72%
common/log/tag/tags.go 3 50.18%
Totals Coverage Status
Change from base Build 018e1b8e-cba9-423b-8be9-19eaebd31881: 0.008%
Covered Lines: 92920
Relevant Lines: 146598

💛 - Coveralls

@agautam478 agautam478 merged commit 832700b into cadence-workflow:master Mar 8, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants