Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a test for the GetworkflowExecution in the nosql_execution_store.go file. #5692

Merged
merged 4 commits into from
Feb 28, 2024

Conversation

agautam478
Copy link
Contributor

@agautam478 agautam478 commented Feb 26, 2024

What changed?
To reduce duplication and improve the test file, I refactored the common setup into helper functions. This refactoring will focus on making the code more maintainable and concise.
Added two new test cases for the GetworkflowExecution.

I will add 5-6 more cases for this in the upcoming PR along with a test for UpdateWorkflowExecution.

Why?
To increase the code coverage.

How did you test it?
unit test

Potential risks
NA

Release notes
NA

Documentation Changes

@coveralls
Copy link

coveralls commented Feb 27, 2024

Pull Request Test Coverage Report for Build 018ded46-e206-4359-adc1-aa5cf08f45c2

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 87 unchanged lines in 20 files lost coverage.
  • Overall coverage decreased (-0.02%) to 62.856%

Files with Coverage Reduction New Missed Lines %
common/persistence/sql/common.go 2 72.73%
common/persistence/sql/sqlplugin/mysql/db.go 2 83.33%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
common/persistence/sql/sqlplugin/postgres/db.go 2 85.0%
common/persistence/sql/sqlplugin/postgres/task.go 2 73.4%
common/task/parallel_task_processor.go 2 93.06%
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
service/history/execution/mutable_state_builder.go 2 68.74%
service/history/shard/context.go 2 66.52%
service/matching/db.go 2 73.23%
Totals Coverage Status
Change from base Build 018de6a8-86c7-4d74-a3c6-13b680f6e3fd: -0.02%
Covered Lines: 92903
Relevant Lines: 147804

💛 - Coveralls

@agautam478 agautam478 enabled auto-merge (squash) February 28, 2024 01:15
@agautam478 agautam478 merged commit 9cefff5 into cadence-workflow:master Feb 28, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants