-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write tests for cdb (Cassandra DB wrapper) basic functions #5686
Merged
taylanisikdemir
merged 3 commits into
cadence-workflow:master
from
taylanisikdemir:taylan/cdb_test
Feb 22, 2024
Merged
Write tests for cdb (Cassandra DB wrapper) basic functions #5686
taylanisikdemir
merged 3 commits into
cadence-workflow:master
from
taylanisikdemir:taylan/cdb_test
Feb 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylanisikdemir
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx and
demirkayaender
as code owners
February 22, 2024 20:15
taylanisikdemir
force-pushed
the
taylan/cdb_test
branch
2 times, most recently
from
February 22, 2024 21:42
2ea616c
to
0115389
Compare
Pull Request Test Coverage Report for Build 018dd2c4-d5dc-4f4a-8089-0d0290881cd5Details
💛 - Coveralls |
taylanisikdemir
force-pushed
the
taylan/cdb_test
branch
from
February 22, 2024 22:30
0115389
to
f67e824
Compare
timl3136
reviewed
Feb 22, 2024
timl3136
reviewed
Feb 22, 2024
Shaddoll
reviewed
Feb 22, 2024
Shaddoll
reviewed
Feb 22, 2024
taylanisikdemir
force-pushed
the
taylan/cdb_test
branch
from
February 22, 2024 23:24
f67e824
to
c6c27d4
Compare
Shaddoll
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Adding tests for
common/persistence/nosql/nosqlplugin/cassandra/db.go
Why?
Increase coverage