-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async workflows integration test with kafka #5678
Merged
taylanisikdemir
merged 7 commits into
cadence-workflow:master
from
taylanisikdemir:taylan/async_wf_integration_test
Feb 21, 2024
Merged
Async workflows integration test with kafka #5678
taylanisikdemir
merged 7 commits into
cadence-workflow:master
from
taylanisikdemir:taylan/async_wf_integration_test
Feb 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylanisikdemir
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx and
demirkayaender
as code owners
February 21, 2024 05:58
Shaddoll
reviewed
Feb 21, 2024
Shaddoll
reviewed
Feb 21, 2024
Shaddoll
reviewed
Feb 21, 2024
Shaddoll
reviewed
Feb 21, 2024
Shaddoll
reviewed
Feb 21, 2024
taylanisikdemir
force-pushed
the
taylan/async_wf_integration_test
branch
from
February 21, 2024 19:36
52518f3
to
6f0b962
Compare
taylanisikdemir
commented
Feb 21, 2024
Shaddoll
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added an integration test to validate StartWorkflowExecutionAsync works. Due to the existing limitations and complicated nature of the integration test framework I had to make some enhancements.
Async WF Consumer side changes:
Test changes:
Why?
Covering the new async workflows feature via an integration test to see start workflow path works e2e.
How did you test it?
docker-compose -f docker/buildkite/docker-compose-local-async-wf.yml down
docker-compose -f docker/buildkite/docker-compose-local-async-wf.yml build integration-test-async-wf
docker-compose -f docker/buildkite/docker-compose-local-async-wf.yml run --rm integration-test-async-wf