Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage for sql_execution_store_util #5676

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

Shaddoll
Copy link
Contributor

What changed?
Add unit tests for createTimerTasks, createCrossClusterTasks and createReplicationTasks functions

Why?
Improve test coverage

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

@Shaddoll Shaddoll enabled auto-merge (squash) February 20, 2024 23:52
@coveralls
Copy link

coveralls commented Feb 21, 2024

Pull Request Test Coverage Report for Build 018dc8ef-a587-4b75-ab96-6118426ace80

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 107 unchanged lines in 13 files lost coverage.
  • Overall coverage increased (+0.04%) to 62.766%

Files with Coverage Reduction New Missed Lines %
common/persistence/historyManager.go 2 66.67%
common/task/weighted_round_robin_task_scheduler.go 2 88.06%
service/frontend/api/handler.go 2 62.17%
common/archiver/filestore/historyArchiver.go 4 80.95%
common/task/fifo_task_scheduler.go 4 85.57%
service/history/task/fetcher.go 4 85.05%
service/history/task/transfer_standby_task_executor.go 4 87.84%
service/matching/taskListManager.go 5 80.2%
common/persistence/statsComputer.go 6 93.57%
service/frontend/wrappers/metered/metered.go 9 62.02%
Totals Coverage Status
Change from base Build 018dc86c-7c7f-47df-a351-981aa1d96cc2: 0.04%
Covered Lines: 92684
Relevant Lines: 147666

💛 - Coveralls

@Shaddoll Shaddoll merged commit 3626935 into cadence-workflow:master Feb 21, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants