Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added debug information for decision timeout handling #5674

Merged

Conversation

3vilhamster
Copy link
Contributor

What changed?
I've aded a metric dimension for decision type timeout metric.
Also, added a domain name tag to the log message that can allow stakeholders debugging issues.

Why?
To provide stakeholders runbook to handle schedule_to_start events

How did you test it?
Unit tests.

Potential risks
For huge clusters with a lot of domains and a lot of workflow types, metric dimension can cause increase in cardinality.

Release notes
Added debug information for decision schedule_to_start.

Documentation Changes

Copy link
Contributor

@taylanisikdemir taylanisikdemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run it locally to check emitted metrics?

@coveralls
Copy link

coveralls commented Feb 21, 2024

Pull Request Test Coverage Report for Build 018dcc26-903b-4401-abf3-7131aa2dd918

Details

  • -8 of 31 (74.19%) changed or added relevant lines in 1 file are covered.
  • 42 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.01%) to 62.779%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/history/task/timer_active_task_executor.go 23 31 74.19%
Files with Coverage Reduction New Missed Lines %
service/history/execution/mutable_state_task_refresher.go 1 73.42%
common/task/fifo_task_scheduler.go 2 87.63%
common/task/parallel_task_processor.go 2 93.06%
service/history/task/transfer_standby_task_executor.go 2 87.42%
service/matching/matcher.go 2 90.72%
service/matching/taskListManager.go 2 79.7%
service/history/queue/timer_gate.go 3 95.83%
service/history/queue/timer_queue_processor_base.go 3 77.82%
service/frontend/api/handler.go 5 62.11%
service/history/task/task_util.go 20 70.57%
Totals Coverage Status
Change from base Build 018dc926-14ca-4ed7-82ff-93d34d582624: 0.01%
Covered Lines: 92722
Relevant Lines: 147695

💛 - Coveralls

@3vilhamster 3vilhamster merged commit 4a0c4da into cadence-workflow:master Feb 21, 2024
16 checks passed
@3vilhamster 3vilhamster deleted the schedule_to_start_debug branch February 21, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants