-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add async workflow request consumer for Start/SignalWithStart support #5658
Merged
taylanisikdemir
merged 5 commits into
cadence-workflow:master
from
taylanisikdemir:taylan/async_wf_consumer
Feb 14, 2024
Merged
Add async workflow request consumer for Start/SignalWithStart support #5658
taylanisikdemir
merged 5 commits into
cadence-workflow:master
from
taylanisikdemir:taylan/async_wf_consumer
Feb 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylanisikdemir
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx and
demirkayaender
as code owners
February 13, 2024 00:46
service/worker/asyncworkflow/async_workflow_consumer_manager.go
Outdated
Show resolved
Hide resolved
taylanisikdemir
force-pushed
the
taylan/async_wf_consumer
branch
from
February 13, 2024 17:46
385f9a9
to
5ec3cf6
Compare
taylanisikdemir
changed the title
Async workflow request consumer
Add async workflow request consumer for Start/SignalWithStart support
Feb 13, 2024
Shaddoll
reviewed
Feb 13, 2024
Shaddoll
reviewed
Feb 13, 2024
Shaddoll
reviewed
Feb 13, 2024
taylanisikdemir
force-pushed
the
taylan/async_wf_consumer
branch
from
February 13, 2024 23:03
a798b63
to
2a20ad6
Compare
Shaddoll
approved these changes
Feb 14, 2024
taylanisikdemir
force-pushed
the
taylan/async_wf_consumer
branch
from
February 14, 2024 04:27
2a20ad6
to
de45061
Compare
taylanisikdemir
merged commit Feb 14, 2024
eea917e
into
cadence-workflow:master
14 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Implemented Async workflow request consumer component which will consume requests from queue and call corresponding frontend API (sync version of the request). It currently support following async request types:
How did you test it?
Added unit tests. Integration and bench tests are coming soon.