Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small refactoring in history task processors #5566

Merged
merged 2 commits into from
Dec 29, 2023
Merged

Small refactoring in history task processors #5566

merged 2 commits into from
Dec 29, 2023

Conversation

taylanisikdemir
Copy link
Contributor

What changed?

  • Task scheduler option structs are moved into separate files under common/task folder
  • Unit tests are added to cover concrete scheduler option creation
  • Debug logs are added to include task scheduling options details
  • Some constants are moved to local package
  • Some files renamed to snake_case

Why?
To improve debugging and better code organization

How did you test it?
make test

3vilhamster
3vilhamster approved these changes Dec 29, 2023
View reviewed changes
Copy link
Contributor

@3vilhamster 3vilhamster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taylanisikdemir taylanisikdemir merged commit f632c0c into cadence-workflow:master Dec 29, 2023
16 checks passed
@taylanisikdemir taylanisikdemir deleted the taylan/task_proc_refactor branch December 29, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3vilhamster 3vilhamster 3vilhamster approved these changes

@davidporter-id-au davidporter-id-au davidporter-id-au left review comments

@Shaddoll Shaddoll Awaiting requested review from Shaddoll Shaddoll is a code owner

@neil-xie neil-xie Awaiting requested review from neil-xie neil-xie is a code owner

@Groxx Groxx Awaiting requested review from Groxx Groxx is a code owner

@shijiesheng shijiesheng Awaiting requested review from shijiesheng shijiesheng is a code owner

@agautam478 agautam478 Awaiting requested review from agautam478

@jakobht jakobht Awaiting requested review from jakobht jakobht is a code owner

@sankari165 sankari165 Awaiting requested review from sankari165 sankari165 is a code owner

@dkrotx dkrotx Awaiting requested review from dkrotx dkrotx is a code owner

@demirkayaender demirkayaender Awaiting requested review from demirkayaender demirkayaender is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taylanisikdemir @davidporter-id-au @3vilhamster