Add shard id to queue processor related metrics #5557
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
History's queue processors are created per shard by history engine. Logs had shard-id tag but metrics were missing it. So adding shard id tag to relevant metrics.
Why?
To improve overall monitoring of queue processor operations.
How did you test it?
Potential risks
We default to 16k shards so cardinality of these queue processor metrics shouldn't be an issue. There's not other high cardinality tags in those metrics.