Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no idea why invalid
sh
syntax isn't a script failure, but the checkmark is still green:and apparently that documented environment variable doesn't actually exist.
BUILDKITE=true
exists though and it seems reasonable.and I forgot that
>&1
only captures stdout (and redirects it to stdout), so stderr was still being missed.this is all so very crazy.
but after throwing enough stuff at the wall and testing with a non-clean git status, this appears to work and makes sense.
this should also catch "dir changed and safe-directory no longer works", unlike before, so we can notice and fix it more quickly.