Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More fixes for golint.sh #5519

Merged
merged 9 commits into from
Dec 21, 2023
Merged

More fixes for golint.sh #5519

merged 9 commits into from
Dec 21, 2023

Conversation

Groxx
Copy link
Contributor

@Groxx Groxx commented Dec 21, 2023

I have no idea why invalid sh syntax isn't a script failure, but the checkmark is still green:

./scripts/buildkite/golint.sh: 12: [[: not found
+ git status --porcelain
fatal: detected dubious ownership in repository at '/cadence'
To add an exception for this directory, call:
	git config --global --add safe.directory /cadence
+ [ -n  ]

and apparently that documented environment variable doesn't actually exist.
BUILDKITE=true exists though and it seems reasonable.

and I forgot that >&1 only captures stdout (and redirects it to stdout), so stderr was still being missed.

this is all so very crazy.

but after throwing enough stuff at the wall and testing with a non-clean git status, this appears to work and makes sense.
this should also catch "dir changed and safe-directory no longer works", unlike before, so we can notice and fix it more quickly.

@Groxx Groxx enabled auto-merge (squash) December 21, 2023 04:09
@Groxx Groxx merged commit 1ef976b into cadence-workflow:master Dec 21, 2023
16 checks passed
@Groxx Groxx deleted the lint branch December 21, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants