fix scavenger test suite #5490
Merged
fix scavenger test suite #5490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3vilhamster
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
3vilhamster
force-pushed
the
fix-scavenger-test-suite
branch
from
04267ca
to
1fd5723
Compare
taylanisikdemir
approved these changes
Dec 18, 2023
3vilhamster
force-pushed
the
fix-scavenger-test-suite
branch
from
1fd5723
to
b62c9ad
Compare
| waiter := make(chan struct{}) | ||
|
|
||
| go func() { | ||
| s.scvgr.stopWG.Wait() |
There was a problem hiding this comment.
I missed this during review. s.scvgr.Stop() is never called in tests and instead the passed ctx is expected to cancel after hardcoded 10s. Seems like that suite could be improved to manage lifecycle better and be self contained per test case.
There was a problem hiding this comment.
It is Stopped by the Scavenger itself after the run goroutine is finished.
The only possibility to leak goroutine/log is if the test times out, though the test will fail in this case.
There was a problem hiding this comment.
Kind of a fix #5510
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fixed ScavengerTestSuite not waiting for the stop of the running scavenger.
Why?
The tests were leaking goroutine and logging outside of tests that can lead to panic: Log in goroutine after '' has completed
How did you test it?
unit tests with count=100
Potential risks
Release notes
Documentation Changes