Create and use a limiter struct instead of just passing a function #5454
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a limiter struct and interface instead of just passing a function - will create dedicated factories later
What changed?
We now parse a LimiterFactory to the quotas.Collection instead of just a function, this gives the code more structure
Why?
The code is very hard to read when all state are kept in closures
How did you test it?
Unit tests still pass
Potential risks
Release notes
Documentation Changes