Adding a metric for hosts not being found in resolver #5414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidporter-id-au
changed the title
dkrotx
reviewed
Oct 8, 2023
common/membership/resolver.go
Outdated
| @@ -193,6 +198,7 @@ func (rpo *MultiringResolver) Unsubscribe(service string, name string) error { | |||
| func (rpo *MultiringResolver) Members(service string) ([]HostInfo, error) { | |||
| ring, err := rpo.getRing(service) | |||
| if err != nil { | |||
| rpo.metrics.Scope(metrics.ResolverHostNotFoundScope).IncCounter(1) | |||
There was a problem hiding this comment.
Isn't it better to move to LookupByAddress() which calls Members?
Then it would be clear - every time LookupByAddress returns empty HostInfo we emit the metric.
There was a problem hiding this comment.
yes, you're right, I was being a bit hurried and this doesn't make sense
dkrotx
approved these changes
Oct 8, 2023
3vilhamster
reviewed
Oct 10, 2023
common/membership/resolver.go
Outdated
| @@ -26,6 +26,7 @@ package membership | |||
| import ( | |||
| "errors" | |||
| "fmt" | |||
| "github.com/uber/cadence/common/metrics" | |||
There was a problem hiding this comment.
imports are messed up.
common/membership/resolver_test.go
Outdated
| @@ -23,6 +23,7 @@ | |||
| package membership | |||
|
|
|||
| import ( | |||
| "github.com/uber/cadence/common/metrics" | |||
davidporter-id-au
requested review from
Shaddoll,
neil-xie,
Groxx,
shijiesheng,
agautam478,
jakobht,
sankari165,
taylanisikdemir and
demirkayaender
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Adds a metric around hosts not being visible in the resolver. This is for debugging and early alerting, though it's normal for this metric to appear during rebalancing or deployments temporarily. Long periods of this metric firing may indicate a problem with service discovery.
Why?
How did you test it?
Potential risks
Release notes
Documentation Changes