Debug es-analyzer: workable workflow type counts (#6206)

* handle index name and table name to avoid nil pointer * delete the offset clause
cadence-workflow · Aug 2, 2024 · a56d386 · a56d386
1 parent 196d14b
commit a56d386
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/service/worker/esanalyzer/analyzer.go b/service/worker/esanalyzer/analyzer.go
@@ -119,10 +119,17 @@ func New(
 	config *Config,
 ) *Analyzer {
 	var mode readMode
+	var indexName string
+	var pinotTableName string
+
 	if esClient != nil {
 		mode = ES
+		indexName = esConfig.Indices[common.VisibilityAppName]
+		pinotTableName = ""
 	} else if pinotClient != nil {
 		mode = Pinot
+		indexName = ""
+		pinotTableName = pinotConfig.Table
 	}
 
 	return &Analyzer{
@@ -134,8 +141,8 @@ func New(
 		readMode:            mode,
 		logger:              logger,
 		tallyScope:          tallyScope,
-		visibilityIndexName: esConfig.Indices[common.VisibilityAppName],
-		pinotTableName:      pinotConfig.Table,
+		visibilityIndexName: indexName,
+		pinotTableName:      pinotTableName,
 		resource:            resource,
 		domainCache:         domainCache,
 		config:              config,

diff --git a/service/worker/esanalyzer/domainWorkflowTypeCountWorkflow.go b/service/worker/esanalyzer/domainWorkflowTypeCountWorkflow.go
@@ -182,7 +182,6 @@ AND StartTime > 0
 GROUP BY WorkflowType
 ORDER BY count
 LIMIT 10
-OFFSET 0
     `, w.analyzer.pinotTableName, domain.GetInfo().ID), nil
 }
 

diff --git a/service/worker/esanalyzer/workflow.go b/service/worker/esanalyzer/workflow.go
@@ -164,7 +164,6 @@ WHERE DomainID = '%s'
 GROUP BY WorkflowType
 ORDER BY count DESC
 LIMIT 10
-OFFSET 0
     `, w.analyzer.pinotTableName, domain.GetInfo().ID), nil
 }
 
@@ -185,7 +184,6 @@ WHERE DomainID = '%s'
 GROUP BY JSON_EXTRACT_SCALAR(Attr, '$.CadenceChangeVersion', 'STRING_ARRAY') AS CadenceChangeVersion
 ORDER BY count DESC
 LIMIT 10
-OFFSET 0
     `, w.analyzer.pinotTableName, domain.GetInfo().ID, wfType), nil
 }