-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caddy2 fix tests #109
Caddy2 fix tests #109
Conversation
fd4e400
to
d8bcbc2
Compare
@johnzhanghua Thanks for the PR, some of the changes introduced this issue:
|
d8bcbc2
to
b6e5de1
Compare
Sorry, fixed. |
@johnzhanghua GoSec issues are gone, some of the tests still fail |
@johnzhanghua You can run them locally using |
7c03c9d
to
c65b261
Compare
Added a wait, should be fine now. Tested locally with Docker ubuntu. Could you please trigger the checks ? |
…e as before Signed-off-by: johnzhanghua <[email protected]>
…different from different server Signed-off-by: johnzhanghua <[email protected]>
c65b261
to
5b6051e
Compare
@johnzhanghua Awesome, will start reviewing |
@johnzhanghua Thank you for the PR, I will keep working on the |
1. What does this change do, exactly?
This change based on the PR 74 , to fix the broken test cases
2. Please link to the relevant issues.
PR 74 tests failed
3. Which documentation changes (if any) need to be made because of this PR?
4. Checklist