feat: add first_exist_fallback strategy for try_files #6699
+40
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand why Edit: Nevermind. It's failing because we're not handling forks properly in that job. |
dunglas
changed the title
dunglas
force-pushed
the
first_exist_or_fallback
branch
from
16ba652
to
f3444af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using modern frameworks such as Symfony and Laravel, by convention, all requests are handled by a front controller named
index.phpin the document root.Currently, Caddy does a call to
fs.Stat()at each request to check that this file exists, but in case we use such a framework, this call is useless because we know that the file exists.This PR adds a new
first_exist_fallbackpolicy that assumes that the last file in the list always exists.