fileserver: Add file_limit option for browse
#6648
Open
+62
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
atakanyenel
force-pushed
the
master
branch
2 times, most recently
from
d95c79e
to
1327fc6
Compare
francislavoie
changed the title
file_limit option for browse
atakanyenel
force-pushed
the
master
branch
2 times, most recently
from
48c5441
to
5a5452d
Compare
francislavoie
requested changes
Oct 21, 2024
atakanyenel
force-pushed
the
master
branch
3 times, most recently
from
6d3dd2d
to
05261ec
Compare
francislavoie
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Thanks!
For bonus points, it could probably use an adapt test (can just add it to an existing file_server test) to make sure it produces the correct JSON.
|
Thanks! This LGTM, but before I merge I have just one stupid nit: should it be called Similarly, |
|
I added the test and updated the constant name. I'm keeping the config name still as "file_limit". I can also change that if required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue #6644 . I'm not sure about the config name
file_limit, I prefermax_dir_limitetc.The default is still 10000.As mentioned in the issue, this PR gave me some background on file serve, so I will try to look at paging as well. Please feel free to edit any documentation as you see fit.