reverseproxy: Use correct cases for websocket related headers #6621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francislavoie
changed the title
francislavoie
approved these changes
Oct 11, 2024
francislavoie
force-pushed
the
websocket-normalize
branch
from
34efb78
to
6bad0e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix https://caddy.community/t/websockets-fail-venus-os-cerbo-gx-victron/25685
Although websocket related headers should be handled case insensitively. Some legacy servers and clients do handle them strictly according to rfc. traefik handles this case too. Popular golang websocket libraries such as gorilla also use the correct case.