Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caddytls: Drop rate_limit and burst, has been deprecated #6611

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

francislavoie
Copy link
Member

It's time to get rid of these, they're not working correctly and introduce more problems than they solve, when used.

Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only thing I can think of is a "TODO:" comment above the Caddyfile options parsing to remind us to remove even those errors from the code after some time.

@mholt mholt added this to the v2.9.0-beta.3 milestone Oct 7, 2024
@francislavoie
Copy link
Member Author

I guess so, but no harm if they stay there forever tbh. 2 liners are pretty free.

@francislavoie francislavoie merged commit d7564d6 into master Oct 7, 2024
33 checks passed
@francislavoie francislavoie deleted the drop-ondemand-ratelimit branch October 7, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants