Caddyfile support for TLS handshake matchers #6461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks! I'm curious where this will be used. The Caddyfile tends to abstract away TLS configuration matching. |
|
It is a part of mholt/caddy-l4#217 code that I propose to move here for consistency. It will be used in layer4 module configuration. |
- caddytls.MatchLocalIP - caddytls.MatchRemoteIP - caddytls.MatchServerName
vnxme
force-pushed
the
caddyfile-caddytls-matchers
branch
from
ffd177b
to
eb6a04d
Compare
|
Rebased it on master. Don't know why linter is failing. |
|
The linter config we have is picky about grouping and ordering of imports. I'll circle back in a bit with a command to fix it |
- fix imports order Co-authored-by: Francis Lavoie <[email protected]>
vnxme
force-pushed
the
caddyfile-caddytls-matchers
branch
from
0c48ee3
to
f0817fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to mholt/caddy-l4#217. It implements caddyfile support for TLS handshake matchers:
local_ipby caddytls.MatchLocalIPremote_ipby caddytls.MatchRemoteIPsniby caddytls.MatchServerNameP.S. I noticed, we have NotRanges in caddytls.MatchRemoteIP, but don't have them in caddytls.MatchLocalIP. Shall we fix this inconsistency as well?