Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: prepare syso files for windows embedding in release #6406

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

WeidiDeng
Copy link
Member

No description provided.

@mohammed90 mohammed90 changed the title prepare syso files for windows embedding ci: prepare syso files for windows embedding in release Aug 29, 2024
@mohammed90 mohammed90 added the feature ⚙️ New feature or request label Aug 29, 2024
@mohammed90 mohammed90 added this to the v2.8.5 milestone Aug 29, 2024
Copy link
Member

@mohammed90 mohammed90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking forever. LGTM!! Thank you

@mohammed90 mohammed90 enabled auto-merge (squash) August 29, 2024 20:06
@mohammed90 mohammed90 merged commit 141c785 into master Aug 29, 2024
30 of 33 checks passed
@mohammed90 mohammed90 deleted the windows-icon branch August 29, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ⚙️ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants