Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

caddyhttp: Fix merging consecutive client_ip or remote_ip matchers #6350

Merged
merged 1 commit into from
May 30, 2024
Merged

caddyhttp: Fix merging consecutive client_ip or remote_ip matchers #6350

merged 1 commit into from
May 30, 2024

Conversation

francislavoie
Copy link
Member

Fixes #6349

@francislavoie francislavoie requested a review from mholt May 30, 2024 07:37
@francislavoie francislavoie added the bug 🐞 Something isn't working label May 30, 2024
mholt
mholt approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch Francis. 👍

@mholt mholt merged commit 40c582c into master May 30, 2024
23 checks passed
@mholt mholt deleted the merge-ip-matchers branch May 30, 2024 13:32
@mholt mholt added this to the v2.8.1 milestone May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
bug 🐞 Something isn't working
Projects
None yet
Milestone
v2.8.1
Development

Successfully merging this pull request may close these issues.

Client_ip not merged as remote_ip used to in "not" expression
2 participants
@francislavoie @mholt