-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rewrite: Implement uri query
operations
#6120
rewrite: Implement uri query
operations
#6120
Conversation
3050813
to
fadd6c2
Compare
Yeah, good start.Couple things I notice off the bat:
|
95e372a
to
a10e256
Compare
@francislavoie, out of the list of operations in the issue, which ones you think we should add on top of what we have here at the moment? |
I think rename would be good to have. The defaulting operation isn't necessary. Value replacement would also be good to have. We don't have to implement those right away though, we can add them in a follow-up. |
I just added rename. We can add replace later as it looked a little bit more involved (especially if we want to use regex like for the headers). Please let me know if any modifications are still necessary in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really good! :) Nice work. Just a couple nits from my first pass. Probably ready to move out of draft state.
uri query
operations
afbcbc2
to
5dffc2b
Compare
@mholt Thanks for the round of review! All your feedback items should now be resolved. I also removed the draft status from the PR. |
All the discussions above (except for the order of operations) should now be resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good to go -- let's give it a shot! Nice work @armadi1809 :)
51c2d47
to
a87408e
Compare
a87408e
to
84abc77
Compare
@francislavoie This is my Initial take at #6096. This is still to be improved as only add, delete and set are implemented, but I wanted to get your initial feedback on the overall architecture of the solution before implementing the remaining operations.