Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

templates: Add dummy RemoteAddr to httpInclude request, proxy compatibility #5845

Merged
merged 5 commits into from
Oct 7, 2023
Merged

templates: Add dummy RemoteAddr to httpInclude request, proxy compatibility #5845

merged 5 commits into from
Oct 7, 2023

Commits on Oct 6, 2023

  1. Enhancement: Allow X-Forwarded-For Header in httpInclude Virtual Requ… 

    …ests

The goal of this enhancement is to modify the funcHTTPInclude function in the Caddy codebase to include the X-Forwarded-For header in the virtual request. This change will enable reverse proxies to set the X-Forwarded-For header, ensuring that the client's IP address is correctly provided to the target endpoint. This modification is essential for applications that depend on the X-Forwarded-For header for various functionalities, such as authentication, logging, or content customization.
    @ThanmayNath @francislavoie
    ThanmayNath authored and francislavoie committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    e580f2c View commit details
    Browse the repository at this point in the history

  2. Updated tplcontext.go - set virtReq.RemoteAddr = "127.0.0.1" 

    i have made the suggested changes
    @ThanmayNath @francislavoie
    ThanmayNath authored and francislavoie committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    5d71f3a View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review

    @francislavoie
    francislavoie committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    ee4b650 View commit details
    Browse the repository at this point in the history

  4. Update modules/caddyhttp/templates/tplcontext.go

    @francislavoie
    francislavoie authored Oct 6, 2023
    Configuration menu
    Copy the full SHA
    a98d7b5 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into master

    @ThanmayNath
    ThanmayNath authored Oct 6, 2023
    Configuration menu
    Copy the full SHA
    908a692 View commit details
    Browse the repository at this point in the history