Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace placeholder for file_server index #4679

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Replace placeholder for file_server index #4679

merged 1 commit into from
Apr 7, 2022

Conversation

u5surf
Copy link
Contributor

@u5surf u5surf commented Apr 5, 2022

Fix #4671

Basically I added replaceAll for indexPage.

mholt
mholt approved these changes Apr 7, 2022
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, this should work. Thanks for the contribution and the test!

@mholt mholt added this to the v2.5.0 milestone Apr 7, 2022
@mholt mholt merged commit afca242 into caddyserver:master Apr 7, 2022
@francislavoie francislavoie added the feature ⚙️ New feature or request label Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
feature ⚙️ New feature or request
Projects
None yet
Milestone
v2.5.0
Development

Successfully merging this pull request may close these issues.

Request: add placeholder substitution for file_server fields
3 participants
@u5surf @mholt @francislavoie