Fix http3 servers dying after reload #4654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mholt
approved these changes
Mar 22, 2022
| // fakeClosedErr returns an error value that is not temporary | ||
| // nor a timeout, suitable for making the caller think the | ||
| // listener is actually closed | ||
| func (fcl *fakeCloseListener) fakeClosedErr() error { | ||
| func fakeClosedErr(l interface{ Addr() net.Addr }) error { |
JeDaYoshi
approved these changes
Mar 22, 2022
|
Thank you @marten-seemann! Might as well merge in the optimization in the same PR. |
francislavoie
approved these changes
Mar 22, 2022
- Added caddy.ListenQUIC which returns a QUIC listener valid for reloading in Caddy (for example reloading the http3 server). - Finally resolved issues encountered in #2727
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should finally resolve issues with http3 servers dying after Caddy's reload. Currently it pins the quic-go dependency to the commit in lucas-clemente/quic-go where the necessary changes are made. I've tested everything out locally and used pprof to check that no goroutines are being leaked.
for reloading in Caddy (for example reloading the http3 server).